[18.0][MIG] account_move_base_import: migration to 18.0 #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force import partner on account.move
…be completed manually
…eed to fill all computed and related field
…econciled to false to avoid having a null value instead
When importing a batch for a journal which has a currency different from the company currency, the values in the batch files are in the currency of the journal. The previous code was creating move lines as if the amounts in the batch file were in the company currency. We fix this by checking for the case, and converting the amounts the company currency at the rate of the date of the transaction to fill in the credit / debit columns, and setting the value of amount_currency to the value in the batch file.
Currently translated at 37.9% (41 of 108 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/pt_BR/
Currently translated at 100.0% (108 of 108 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/es/
Currently translated at 0.9% (1 of 108 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/fr/
Currently translated at 100.0% (108 of 108 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/es/
Currently translated at 20.3% (22 of 108 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/ca/
Currently translated at 11.1% (12 of 108 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/it/
Currently translated at 100.0% (108 of 108 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/pt_BR/
…e custom logic (multiple commission fields for instance)
Currently translated at 100.0% (107 of 107 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/sv/
Currently translated at 21.4% (23 of 107 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/ca/
Currently translated at 39.2% (42 of 107 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/it/
Currently translated at 100.0% (107 of 107 strings) Translation: account-reconcile-16.0/account-reconcile-16.0-account_move_base_import Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/pt_BR/
Ricardoalso
force-pushed
the
18.0-mig-account_move_base_import
branch
from
babc52c to
9892aa5
Compare
Ricardoalso
force-pushed
the
18.0-mig-account_move_base_import
branch
3 times, most recently
from
05ec25e to
6a0582e
Compare
Ricardoalso
force-pushed
the
18.0-mig-account_move_base_import
branch
from
6a0582e to
cefbed8
Compare
victorvermot
approved these changes
Feb 11, 2025
| @@ -11,7 +11,6 @@ | |||
| domain="[('used_for_import', '=', True)]" | |||
| /> | |||
| <field name="input_statement" filename="file_name" /> | |||
| <field name="file_name" invisible="1" /> | |||
There was a problem hiding this comment.
You sure about this one ? It won't fail because it does not find file_name in view ?
There was a problem hiding this comment.
Based on the migration documentation for V18
Missing fields used in domains and other attributes are added to the view as invisible automatically. If you encounter fields in views with invisible="True", they can probably be removed. Reference: odoo/odoo#137031
I am not familiar with this module but in the runbot it seams to work like expected
There was a problem hiding this comment.
Oh I missed this one in the V18 doc, thanks for pointing it out !
ivantodorovich
approved these changes
Feb 12, 2025
Comment on lines
+224
to
+226
| "Move %(move_name)s have been imported with %(num_lines)s " "lines." | ||
| ) | ||
| % {"move_name": move.name, "num_lines": num_lines} |
There was a problem hiding this comment.
Suggested change
| "Move %(move_name)s have been imported with %(num_lines)s " "lines." | |
| ) | |
| % {"move_name": move.name, "num_lines": num_lines} | |
| "Move %(move_name)s have been imported with %(num_lines)s lines.", | |
| move_name=move.name, | |
| num_lines=num_lines, | |
| ) |
nitpicking
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.